User:KasumiGhia/onionmacro - Revision history

KasumiGhia at 23:05, 27 November 2010

2010-11-27T23:05:40Z

KasumiGhia at 16:58, 14 September 2010

2010-09-14T16:58:57Z

KasumiGhia: fixed wordwrap

2010-09-14T06:05:24Z

fixed wordwrap

KasumiGhia: my version of Jimbly's onion.lua macro

2010-09-14T05:59:28Z

my version of Jimbly's onion.lua macro

New page

The below is an edited version of [[User:Jimbly]]'s onion planting macro. I'll remove this page if he accepts the fixes herein.

* FIX: if slate shows up it will move the fill water icon, causing the original script to error. This version figures out the location of the icon each time to avoid this.
* FIX: a couple times it couldn't find the location of the new onion plant. I've added additional offsets to find it.
* FIX: The script didn't move back to the starting point correctly, so it ended up walking out of the plantable area. I fixed it so it moves back closer to the right place. (still not perfect though)
* FEATURE: Added prompting for size of area to plant, instead of requiring script editing to change
* TODO: If you use all your seeds the scripts fail when starting the second planting loop. I added code that I thought would fix this, but it doesn't, and I don't know why. Hopefully Jimbly can figure this out.
* FIX: I was experiencing some lag, so A couple of the delays have been increased slightly. It doesn't slow the script down appreciably, and allowed it to work for me.
* NOTE: I also uncommented the delays in the function drag in flax_common.inc, I haven't included those changes here. They may or may not be required if things are lagging. It defiantly helped me.

<pre>
-- Edit these first 2 to adjust how much is planted in a pass
-- Probably not fast enough to do more than 3x3
grid_w = 3;
grid_h = 3;

imgOnionBed = "ThisIsAnOnionBed.png";
imgOnionSeeds = "OnionSeeds.png";
imgWaterThese = "WaterThese.png";
imgHarvestThese = "HarvestThese.png";
imgWaterJugs = "IconWaterJugs.png";

loadfile("luaScripts/flax_common.inc")();
loadfile("luaScripts/screen_reader_common.inc")();
loadfile("luaScripts/ui_utils.inc")();

walk_px_x = 112;
walk_px_y = 112;
walk_time = 250;
screen_refresh_time = 100;
water_time = 1200;
harvest_time = 1100;
fill_water_time = 4000;
pass_growth_time = 24000;

-- the onion window
window_w = 191;
window_h = 84;
refresh_down_y_offs = 0;

search_size = 15;
search_size2 = 10;
search_dx = {0, -search_size, search_size, -search_size, search_size, -search_size, search_size, 0, 0, -search_size2, search_size2,

-search_size2, search_size2, -search_size2, search_size2, 0, 0};
search_dy = {0, -search_size, search_size, search_size, -search_size, 0, 0, -search_size, search_size, -search_size2, search_size2,

search_size2, -search_size2, 0, 0, -search_size2, search_size2};

function fillWater(required)
if (aqueduct_mode) then
aque = srFindImage("Aqueduct.png", 5000);
if not aque then
error 'Could not find aqueduct window.';
end
srClickMouseNoMove(aque[0], aque[1]);
lsSleep(150);
srReadScreen();
fill = srFindImage("FillWithWater.png", 5000);
if ((not fill) and required) then
error 'Could not find Fill With Wather';
end
if fill then
srClickMouseNoMove(fill[0]+5, fill[1]);
end
else
srReadScreen();
xyFillWater = srFindImage(imgWaterJugs);
if not xyFillWater then
error 'CMoved too far for fill jugs with water icon.';
else
-- Use it
srClickMouseNoMove(xyFillWater[0], xyFillWater[1]);
lsSleep(screen_refresh_time);
srClickMouseNoMove(xyCenter[0] + 10, xyCenter[1] + 20);
lsSleep(fill_water_time);
end;
end
num_waters = 0;
end

function doit()
num_jugs = promptNumber("How many jugs?", 15);
grid_w = promptNumber("How many plants across?", grid_w);
grid_h = promptNumber("How many rows of plants?", grid_h);
num_loops = promptNumber("How many " .. grid_w .. "x" .. grid_h .. " passes?", 5);

askForWindow("Make sure the plant Onions window is pinned and you are in F8F8 cam zoomed in. Will plant SE of this

location. 'Plant all crops where you stand' must be ON.");

initGlobals();
num_waters = 0;

srReadScreen();
xyCenter = getCenterPos();

-- Find plant onions window
local xyPlantOnions = srFindImage(imgOnionSeeds);
if not xyPlantOnions then
error 'Could not find plant window';
end
xyPlantOnions[0] = xyPlantOnions[0] + 5;

-- Find aqudeuct or fill water button, use it
aque = srFindImage("Aqueduct.png", 5000);
if not aque then
aqueduct_mode = nil;
xyFillWater = srFindImage(imgWaterJugs);
if not xyFillWater then
error 'Could not find Aqueduct window OR fill jugs with water icon, you may need to empty 1 jug.';
else
-- Use it
fillWater(nil);
end;
else
aqueduct_mode = 1;
fillWater(nil);
end

for loop_count=1, num_loops do

-- Plant and pin
for y=1, grid_h do
for x=1, grid_w do
lsPrintln('doing ' .. x .. ',' .. y);

statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Planting " .. x .. ", " .. y);

-- Plant
srClickMouseNoMove(xyPlantOnions[0], xyPlantOnions[1], 0);
-- lsSleep(delay_time);

-- Move to new location
if x == grid_w then
walk_dy = walk_px_y;
walk_dx = 0;
else
walk_dy = 0;
if y % 2 == 1 then
walk_dx = walk_px_x;
else
walk_dx = -walk_px_x;
end
end
lsPrintln("Moving cntr:" .. xyCenter[0] .. " " .. xyCenter[1] .. " d=" .. walk_dx .. " " ..

walk_dy);
srClickMouseNoMove(xyCenter[0] + walk_dx, xyCenter[1] + walk_dy);
lsSleep(walk_time);

-- Search for menu
xyImagePos = nil;

search_idx = 1;
while not xyImagePos and search_idx <= #search_dx do
click_x = xyCenter[0] - walk_dx + math.floor(search_dx[search_idx] * pixel_scale);
click_y = xyCenter[1] - walk_dy + math.floor(search_dy[search_idx] * pixel_scale);
lsPrintln(' clicking ' .. click_x .. ',' .. click_y);
srClickMouse(click_x, click_y, 1); -- Right click!
lsSleep(screen_refresh_time);
checkBreak();
srReadScreen();
xyImagePos = srFindImageInRange(imgOnionBed, click_x - walk_px_x*2, click_y - 42 -

walk_px_y*2, window_w+walk_px_x*4, window_h+walk_px_y*4);
if xyImagePos then
-- found it
click_x = xyImagePos[0] - 6;
click_y = xyImagePos[1] + 25;
else
-- No menu came up, try elsewhere?
search_idx = search_idx+1;
end
end

if not xyImagePos then
error ' Failed to bring up onion bed window';
end

-- Pin
srClickMouseNoMove(click_x+5, click_y, 1);
lsSleep(screen_refresh_time);

-- Move window
local pp = pinnedPos(x, y);
drag(click_x, click_y,
pp[0], pp[1], 0);
-- lsSleep(delay_time);

checkBreak();
end
end

srSetMousePos(200, 200);

statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Refocusing windows...");

-- Bring windows to front
for y=grid_h, 1, -1 do
for x=grid_w, 1, -1 do
local rp = refreshPosUp(x, y);
srClickMouseNoMove(rp[0], rp[1], 0);
lsSleep(refocus_click_time);
end
end
lsSleep(1000); -- Wait for last window to bring to the foreground before clicking again

-- Water everything and then harvestable
do_harvest = nil;
water_pass_count=0;
passes_before_harvest = 4;
while 1 do
water_pass_count = water_pass_count+1;
start_time = lsGetTimer();
for y=1, grid_h do
for x=1, grid_w do
if do_harvest then
statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Harvesting " .. x .. ", "

.. y);
else
statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Watering " .. x .. ", " ..

y .. " water pass " .. water_pass_count);
end
local pp = pinnedPos(x, y);
local rp = refreshPosDown(x, y);
while 1 do
srClickMouseNoMove(rp[0], rp[1], 0);
lsSleep(screen_refresh_time);
srReadScreen();
if not do_harvest then
local water = srFindImageInRange(imgWaterThese, pp[0], pp[1] - 25,

window_w, window_h);
if water then
srClickMouseNoMove(water[0] + 5, water[1], 0);
lsSleep(water_time);
num_waters = num_waters + 1;
if num_waters >= num_jugs-1 then
fillWater(1);
end
break;
end
end
local harvest = srFindImageInRange(imgHarvestThese, pp[0], pp[1] - 25, window_w,

window_h);
if harvest then
if do_harvest then
-- do the harvest
srClickMouseNoMove(harvest[0] + 5, harvest[1], 0);
-- dismiss window
srClickMouseNoMove(rp[0], rp[1], 1);
lsSleep(harvest_time);
end
-- lsPrintln('Ready for harvest, come back later!');
break;
end
lsSleep(10);
checkBreak();
-- try again anyway! error ' Expected Onion window to have either harvest or

water!';
end
end
end

if do_harvest then
break;
end

-- Bring windows to front
for y=grid_h, 1, -1 do
for x=grid_w, 1, -1 do
local rp = refreshPosUp(x, y);
srClickMouseNoMove(rp[0], rp[1], 0);
lsSleep(refocus_click_time);
end
end
lsSleep(1000); -- Wait for last window to bring to the foreground before clicking again

if water_pass_count == passes_before_harvest then
do_harvest = 1;
else
-- Otherwise, wait until 24 seconds has elapsed, and water again
local time_left = pass_growth_time - (lsGetTimer() - start_time);
statusScreen("Waiting " .. time_left .. "ms before starting next pass...");
if (time_left > fill_water_time) and (num_waters > 0) then
fillWater(1);
end
while pass_growth_time - (lsGetTimer() - start_time) > 0 do
time_left = pass_growth_time - (lsGetTimer() - start_time);
statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Waiting " .. time_left .. "ms

before starting next water pass...");
lsSleep(100);
checkBreak();
end
end
end

lsSleep(2000); -- wait for harvested plants to disappear

-- Move back a bit
if grid_h == 1 then
srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*(grid_w - 1.5)), xyCenter[1]);
elseif grid_w == 1 then
srClickMouseNoMove(xyCenter[0], xyCenter[1] - math.floor(walk_px_y*(grid_h - 1.5)));
else
if grid_h % 2 == 1 then
-- odd number of rows, ends up near bottom right, so move left and up
srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*(grid_w - 1.5)), xyCenter[1] - math.floor

(walk_px_y*(grid_h - 1.5)));
else
-- even number of rows, ends up near bottom left, so move mostly up
srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*.5) , xyCenter[1] - math.floor(walk_px_y*

(grid_h - 1.5)));
end
end
lsSleep(2000); -- wait to move back

--FIXME The below doesn't work. I don't know why. Don't use all your seeds till it's fixed.
-- If we had used all the seeds, then the plant menu is blank and needs to be refreshed.
srReadScreen();
local xytest = srFindImage(imgOnionSeeds);
if not xytest then
-- click where it was to refresh the window
srClickMouseNoMove(xyPlantOnions[0], xyPlantOnions[1], 0);
lsSleep(screen_refresh_time);
end

end

lsPlaySound("Complete.wav");
end
</pre>

@@ Line 1: / Line 1: @@
 The below is an edited version of [[User:Jimbly]]'s onion planting macro.  I'll remove this page if he accepts the fixes herein.
 * FIX: if slate shows up it will move the fill water icon, causing the original script to error.  This version figures out the location of the icon each time to avoid this.  (I think this is working, but I'm not 100% sure, it hasn't happened again for me yet)
 * FIX: a couple times it couldn't find the location of the new onion plant.  I've added additional offsets to find it.
 * FIX: The script didn't move back to the starting point correctly, so it ended up walking out of the plantable area.  I fixed it so it moves back closer to the right place.  (still not perfect though)
-* FEATURE: Added prompting for size of area to plant, instead of requiring script editing to change
 * TODO: If you use all your seeds the scripts fail when starting the second planting loop.  I added code that I thought would fix this, but it doesn't, and I don't know why.  Hopefully Jimbly can figure this out.
 * FIX: I was experiencing some lag, so A couple of the delays have been increased slightly.  It doesn't slow the script down appreciably, and allowed it to work for me.
-* NOTE: I also uncommented the delays in the function drag in flax_common.inc, I haven't included those changes here.  They may or may not be required if things are lagging.  It defiantly helped me.
+* NOTE: I also uncommented the delays in the function drag in flax_common.inc, I haven't included those changes here.  They may or may not be required if things are lagging.  It helped me.
 <pre>
 -- Edit these first 2 to adjust how much is planted in a pass
--- Probably not fast enough to do more than 3x3
+-- Probably not fast enough to do more than 4x4
 grid_w = 3;
 grid_h = 3;
@@ Line 46: / Line 50: @@
 function fillWater(required)
 	if (aqueduct_mode) then
 		aque = srFindImage("Aqueduct.png", 5000);
@@ Line 74: / Line 79: @@
 		end;
 	end
-	num_waters = 0;
+    end;
 end
@@ Line 87: / Line 93: @@
 	initGlobals();
 	num_waters = 0;
 	srReadScreen();
@@ Line 101: / Line 111: @@
 	aque = srFindImage("Aqueduct.png", 5000);
 	if not aque then
 		aqueduct_mode = nil;
 		xyFillWater = srFindImage(imgWaterJugs);
@@ Line 109: / Line 120: @@
 			fillWater(nil);
 		end;
 	else
 		aqueduct_mode = 1;
@@ Line 294: / Line 306: @@
 			else
 				-- even number of rows, ends up near bottom left, so move mostly up
-				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*.5)  , xyCenter[1] - math.floor(walk_px_y*(grid_h - 1.5)));
+				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*1)  , xyCenter[1] - math.floor(walk_px_y*(grid_h - 1.5)));
 			end
 		end
@@ Line 314: / Line 326: @@
 	lsPlaySound("Complete.wav");
 end
 </pre>

@@ Line 41: / Line 41: @@
 search_size = 15;
 search_size2 = 10;
-search_dx = {0, -search_size, search_size, -search_size, search_size, -search_size, search_size, 0, 0, -search_size2, search_size2,
+search_dx = {0, -search_size, search_size, -search_size, search_size, -search_size, search_size, 0, 0, -search_size2, search_size2, -search_size2, search_size2, -search_size2, search_size2, 0, 0};
 search_dy = {0, -search_size, search_size, search_size, -search_size, 0, 0, -search_size, search_size, -search_size2, search_size2, search_size2, -search_size2, 0, 0, -search_size2, search_size2};
@@ Line 87: / Line 83: @@
 	num_loops = promptNumber("How many " .. grid_w .. "x" .. grid_h .. " passes?", 5);
-	askForWindow("Make sure the plant Onions window is pinned and you are in F8F8 cam zoomed in.  Will plant SE of this
+	askForWindow("Make sure the plant Onions window is pinned and you are in F8F8 cam zoomed in.  Will plant SE of this location.  'Plant all crops where you stand' must be ON.");
 	initGlobals();
@@ Line 145: / Line 139: @@
 					end
 				end
-				lsPrintln("Moving cntr:" .. xyCenter[0] .. " " .. xyCenter[1] .. " d=" .. walk_dx .. " " ..
+				lsPrintln("Moving cntr:" .. xyCenter[0] .. " " .. xyCenter[1] .. " d=" .. walk_dx .. " " .. walk_dy);
 				srClickMouseNoMove(xyCenter[0] + walk_dx, xyCenter[1] + walk_dy);
 				lsSleep(walk_time);
@@ Line 163: / Line 155: @@
 					checkBreak();
 					srReadScreen();
-					xyImagePos = srFindImageInRange(imgOnionBed, click_x - walk_px_x*2, click_y - 42 -
+					xyImagePos = srFindImageInRange(imgOnionBed, click_x - walk_px_x*2, click_y - 42 - walk_px_y*2, window_w+walk_px_x*4, window_h+walk_px_y*4);
 					if xyImagePos then
 						-- found it
@@ Line 218: / Line 208: @@
 				for x=1, grid_w do
 					if do_harvest then
-						statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Harvesting " .. x .. ", "
+						statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Harvesting " .. x .. ", " .. y);
 					else
-						statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Watering " .. x .. ", " ..
+						statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Watering " .. x .. ", " .. y .. " water pass " .. water_pass_count);
 					end
 					local pp = pinnedPos(x, y);
@@ Line 233: / Line 219: @@
 						srReadScreen();
 						if not do_harvest then
-							local water = srFindImageInRange(imgWaterThese, pp[0], pp[1] - 25,
+							local water = srFindImageInRange(imgWaterThese, pp[0], pp[1] - 25, window_w, window_h);
 							if water then
 								srClickMouseNoMove(water[0] + 5, water[1], 0);
@@ Line 246: / Line 230: @@
 							end
 						end
-						local harvest = srFindImageInRange(imgHarvestThese, pp[0], pp[1] - 25, window_w,
+						local harvest = srFindImageInRange(imgHarvestThese, pp[0], pp[1] - 25, window_w, window_h);
 						if harvest then
 							if do_harvest then
@@ Line 262: / Line 244: @@
 						lsSleep(10);
 						checkBreak();
-						-- try again anyway!  error ' Expected Onion window to have either harvest or
+						-- try again anyway!  error ' Expected Onion window to have either harvest or water!';
 					end
 				end
@@ Line 294: / Line 274: @@
 				while pass_growth_time - (lsGetTimer() - start_time) > 0 do
 					time_left = pass_growth_time - (lsGetTimer() - start_time);
-					statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Waiting " .. time_left .. "ms
+					statusScreen("(" .. loop_count .. "/" .. num_loops .. ") Waiting " .. time_left .. "ms before starting next water pass...");
 					lsSleep(100);
 					checkBreak();
@@ Line 313: / Line 291: @@
 			if grid_h % 2 == 1 then
 				-- odd number of rows, ends up near bottom right, so move left and up
-				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*(grid_w - 1.5)), xyCenter[1] - math.floor
+				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*(grid_w - 1.5)), xyCenter[1] - math.floor(walk_px_y*(grid_h - 1.5)));
 			else
 				-- even number of rows, ends up near bottom left, so move mostly up
-				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*.5)  , xyCenter[1] - math.floor(walk_px_y*
+				srClickMouseNoMove(xyCenter[0] - math.floor(walk_px_x*.5)  , xyCenter[1] - math.floor(walk_px_y*(grid_h - 1.5)));
 			end
 		end