User:Cegaiel/VeggieTales/Onion - Revision history

Cegaiel at 05:52, 17 December 2011

2011-12-17T05:52:53Z

Cegaiel at 05:03, 17 December 2011

2011-12-17T05:03:52Z

Taral at 07:46, 16 December 2011

2011-12-16T07:46:59Z

Taral at 07:46, 16 December 2011

2011-12-16T07:46:23Z

Cegaiel at 05:06, 16 December 2011

2011-12-16T05:06:36Z

Cegaiel at 04:45, 16 December 2011

2011-12-16T04:45:03Z

Cegaiel at 04:30, 16 December 2011

2011-12-16T04:30:49Z

Taral at 04:01, 16 December 2011

2011-12-16T04:01:16Z

Taral at 03:48, 16 December 2011

2011-12-16T03:48:16Z

Cegaiel at 02:45, 16 December 2011

2011-12-16T02:45:13Z

@@ Line 1: / Line 1: @@
 <B>Credits:</b>
-Note this script is KasumiGhia's Tale 5 [http://www.atitd.org/wiki/tale5/User:KasumiGhia/lua onions2.lua] update, but with a couple of minor updates.
+Note this script is KasumiGhia's Tale 5 [http://www.atitd.org/wiki/tale5/User:KasumiGhia/lua onions2.lua] update, but with some tweaks/updates..
-<b>Updates by [[User:Cegaiel | Cegaiel]]:</b>
+<b>Updates/Tweaks by [[User:Cegaiel | Cegaiel]]:</b>
 *Will now refresh the plant window, after harvesting.
 **This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed).
 **By refreshing the plant window after harvesting, it will not cause an error (Plant window not found) on 2nd and subsequent passes.
-**screen_refresh_time changed from 100 to 300, to help prevent pin up problems on slower computers. This doesn't need to be so fast as the game doesn't really keep up anyways on 5x5 or small grids.
+*screen_refresh_time changed from 100 to 300, to help prevent pin up problems on slower computers. This doesn't need to be so fast as the game doesn't really keep up anyways on 5x5 or small grids.
-**Added instructions in the script that 'Right click Pins/Unpins a Menu' must be ON and 'Right click opens a Menu as pinned' must be OFF.
+*Added instructions in the script that 'Right click Pins/Unpins a Menu' must be ON and 'Right click opens a Menu as pinned' must be OFF.
-<b>Updates by [[User:Taral | Taral]]:</b>
+<b>Updates/Tweaks by [[User:Taral | Taral]]:</b>
 *Found/corrected minor bug where the 'fill jugs' routine was off by 1.
 **If you claim to have enough jugs it is not suppose to ask to refill jugs, at beginning. However this was off by one (ie if you said you have 60 jugs AND if your grid required 60 jugs, you would be required to enter 61 jugs to not force you to refill jugs at beginning).
-**Also condensed my 3 lines of updated code, into 1 line of code (refresh plant window routine).
+*Also condensed my 3 lines of updated code, into 1 line of code (refresh plant window routine).

@@ Line 9: / Line 9: @@
 **By refreshing the plant window after harvesting, it will not cause an error (Plant window not found) on 2nd and subsequent passes.
 **screen_refresh_time changed from 100 to 300, to help prevent pin up problems on slower computers. This doesn't need to be so fast as the game doesn't really keep up anyways on 5x5 or small grids.
@@ Line 24: / Line 25: @@
 <b>Onions.lua:</b>
 <pre>
 imgOnionBed = "ThisIsAnOnionBed.png";
 imgOnionSeeds = "OnionSeeds.png";
@@ Line 97: / Line 95: @@
 	num_loops = promptNumber("How many " .. grid_w .. "x" .. grid_h .. " passes?", 5);
-	askForWindow("Make sure the plant Onions window is pinned and you are in F8F8 cam zoomed in.  Will plant SE of this location.  'Plant all crops where you stand' must be ON.");
+	askForWindow("Make sure the plant Onions window is pinned and you are in F8F8 cam zoomed in.  Will plant SE of this location.\n \n'Plant all crops where you stand' must be ON.  'Right click pins/unpins a menu' must be ON.  'Right click opens Menu as Pinned' must be OFF.");
 	initGlobals();
@@ Line 325: / Line 323: @@
 	lsPlaySound("Complete.wav");
 end
 </pre>

@@ Line 24: / Line 24: @@
 <b>Onions.lua:</b>
 <pre>
-grid_w = 3
+grid_w = 3;
-grid_h = 3
+grid_h = 3;
 imgOnionBed = "ThisIsAnOnionBed.png";

@@ Line 24: / Line 24: @@
 <b>Onions.lua:</b>
 <pre>
 imgOnionBed = "ThisIsAnOnionBed.png";
 imgOnionSeeds = "OnionSeeds.png";

← Older revision		Revision as of 05:06, 16 December 2011
Line 8:		Line 8:
	**This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed).		**This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed).
	**By refreshing the plant window after harvesting, it will not cause an error (Plant window not found) on 2nd and subsequent passes.		**By refreshing the plant window after harvesting, it will not cause an error (Plant window not found) on 2nd and subsequent passes.
		+	**screen_refresh_time changed from 100 to 300, to help prevent pin up problems on slower computers. This doesn't need to be so fast as the game doesn't really keep up anyways on 5x5 or small grids.

← Older revision		Revision as of 04:30, 16 December 2011
Line 1:		Line 1:
−	<B>Credits:</b> Note this script is KasumiGhia's Tale 5 onions2.lua update, but with a minor ~~adjustment~~. It will refresh the plant window, after harvesting. This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed). By refreshing, it will not cause an error (Plant window not found) on 2nd and subsequent passes.	+	<B>Credits:</b>
		+	Note this script is KasumiGhia's Tale 5 onions2.lua update, but with a couple of minor updates.
		+
		+	Thanks to [[User:Taral \| Taral]] for finding and fixing where the fill jugs routine was off by 1. If you claim to have enough jugs it will not ask to refill jugs, however this was off by one (ie if you said you have 60 jugs, you would be required to enter 61 jugs to not force you to refill jugs at beginning). Also for cleaning up my 3 lines of code into 1 line (refresh plant window).
		+
		+
		+	My Update: It will refresh the plant window, after harvesting. This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed). By refreshing, it will not cause an error (Plant window not found) on 2nd and subsequent passes.
		+

@@ Line 33: / Line 33: @@
 walk_px_y = 112;
 walk_time = 250;
-screen_refresh_time = 100;
+screen_refresh_time = 300;
 water_time = 1200;
 harvest_time = 1100;

@@ Line 20: / Line 20: @@
 <b>Onions.lua:</b>
 <pre>
 imgOnionBed = "ThisIsAnOnionBed.png";
 imgOnionSeeds = "OnionSeeds.png";
@@ Line 39: / Line 33: @@
 walk_px_y = 112;
 walk_time = 250;
-screen_refresh_time = 300;
+screen_refresh_time = 100;
 water_time = 1200;
 harvest_time = 1100;
@@ Line 77: / Line 71: @@
 		xyFillWater = srFindImage(imgWaterJugs);
 		if not xyFillWater then
-			error 'CMoved too far for fill jugs with water icon.';
+			error 'Moved too far for fill jugs with water icon.';
 		else
 			-- Use it
@@ Line 101: / Line 95: @@
 	num_waters = 0;
 	water_needed = 1;
-	if num_jugs > (grid_w*grid_h*4*num_loops) then
+	if num_jugs >= (grid_w*grid_h*4*num_loops) then
 		water_needed = false;
 	end;
@@ Line 195: / Line 189: @@
 				-- Move window
 				local pp = pinnedPos(x, y);
-				drag(click_x, click_y,
+				drag(click_x, click_y, pp[0], pp[1], 0);
 				-- lsSleep(delay_time);
@@ Line 243: / Line 236: @@
 								lsSleep(water_time);
 								num_waters = num_waters + 1;
-								if num_waters >= num_jugs-1 then
+								if num_waters >= num_jugs then
 									fillWater(1);
 								end
@@ Line 299: / Line 292: @@
 			end
 		end
 		lsSleep(2000); -- wait for harvested plants to disappear
@@ Line 326: / Line 313: @@
 		end
 		lsSleep(2000); -- wait to move back
 	end

← Older revision		Revision as of 02:45, 16 December 2011
Line 1:		Line 1:
	<B>Credits:</b> Note this script is KasumiGhia's Tale 5 onions2.lua update, but with a minor adjustment. It will refresh the plant window, after harvesting. This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed). By refreshing, it will not cause an error (Plant window not found) on 2nd and subsequent passes.		<B>Credits:</b> Note this script is KasumiGhia's Tale 5 onions2.lua update, but with a minor adjustment. It will refresh the plant window, after harvesting. This is in case you used all your seeds during planting which makes the plant window to be blank (as there are no more seeds in inventory after you planted your last seed). By refreshing, it will not cause an error (Plant window not found) on 2nd and subsequent passes.
		+
		+
		+
		+	Added to Line 283
		+
		+	<pre>
		+	--Click the plant window, to refresh seeds, in case you used your last seed. Prevents fails (can't find onion seed) on 2nd or higher passes.
		+	xyPlantFlax[1] = xyPlantFlax[1] + 15;
		+	srClickMouseNoMove(xyPlantFlax[0], xyPlantFlax[1], 0);
		+	xyPlantFlax[1] = xyPlantFlax[1] - 15;
		+	</pre>
		+